fix: nodedb find wrong latest version with partial committed batch by yihuang · Pull Request #1107 · cosmos/iavl

yihuang · 2025-07-07T02:59:29Z

BatchWithFlusher could separate the commit of the same version into multiple batches, when the batches are not persisted atomically, the current latest version method will return an incomplete version and eventually return error in MutableTree.Load(0) method.

Update CHANGELOG.md cleanup

`BatchWithFlusher` could separate the commit of the same version into multiple batches, when the batches are not persisted atomically, the current latest version method will return an incomplete version and eventually return error in `MutableTree.Load(0)` method.

coderabbitai · 2025-07-07T02:59:35Z

Warning

Rate limit exceeded

@yihuang has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 1 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4c40f and 8d1c18d.

📒 Files selected for processing (4)

CHANGELOG.md (1 hunks)
batch.go (3 hunks)
batch_flusher_test.go (1 hunks)
nodedb.go (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

CHANGELOG.md

mmsqe · 2025-07-07T03:33:02Z

batch_flusher_test.go

+)
+
+type MockDBBatch struct {
+	dbm.Batch


seems they removed dbm.Batch in https://github.com/cosmos/iavl/pull/955/files#diff-367b87ccd372ceca8c6f2e7157b827b4d469318a6571c0cacc99d54c1bb19089

changed to corestore

…rsion

yihuang added 2 commits July 7, 2025 10:56

fix: panic: sync: unlock of unlocked mutex

a8f7024

Update CHANGELOG.md cleanup

yihuang commented Jul 7, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

587d178

yihuang changed the title ~~fix: nodedb find partial latest version in edge cases~~ fix: nodedb find wrong latest version with partial committed version Jul 7, 2025

yihuang changed the title ~~fix: nodedb find wrong latest version with partial committed version~~ fix: nodedb find wrong latest version with partial committed batch Jul 7, 2025

mmsqe reviewed Jul 7, 2025

View reviewed changes

yihuang added 3 commits July 7, 2025 11:36

fix unit test

fd4c6c9

Merge remote-tracking branch 'origin/partial-version' into partial-ve…

03c6517

…rsion

Merge remote-tracking branch 'origin/fix-unlock' into partial-version

8d1c18d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: nodedb find wrong latest version with partial committed batch#1107

fix: nodedb find wrong latest version with partial committed batch#1107
yihuang wants to merge 6 commits intocosmos:masterfrom
yihuang:partial-version

yihuang commented Jul 7, 2025

Uh oh!

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

Rate limit exceeded

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

mmsqe Jul 7, 2025

Uh oh!

yihuang Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

yihuang commented Jul 7, 2025

Uh oh!

coderabbitai bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

mmsqe Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

yihuang Jul 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jul 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)